Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

From: JÃrn Engel
Date: Mon Jun 16 2014 - 21:23:18 EST


On Mon, 16 June 2014 20:46:32 -0400, Nick Krause wrote:
>
> You are right about the compile errors it compiles but with warning.
> I am curious since the function is void how do you want me to
> give the error back to logfs and in turn the other subsystems
> of the kernel.

My first question would be: What is the problem? If there is no
problem, don't try to fix it. If there is a problem, your fix should
contain a decent description of the problem as part of the commit
message. Even if the patch itself ends up being bad, having a good
problem description with a first stab at a fix serves as a useful bug
report.

JÃrn

--
Was there any time in human history where democratic forms continued
when the citizens could not credibly defend their rights?
-- Daniel Suarez
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/