Re: [PATCH 11/21] mfd: use devm_irq_of_parse_and_map() where appropriate

From: Lee Jones
Date: Wed Jun 18 2014 - 04:48:52 EST


On Tue, 17 Jun 2014, Nikita Yushchenko wrote:
> 17.06.2014 19:12, Lee Jones ÐÐÑÐÑ:
> >>From: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>
> >>
> >>This avoids leak of IRQ mapping on error paths, and makes it possible
> >>to use devm_request_irq() without facing unmap-while-handler-installed
> >>issues.
> >>
> >>Signed-off-by: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>
> >>---
> >> drivers/mfd/max8997.c | 4 +++-
> >> drivers/mfd/max8998.c | 4 +++-
> >> 2 files changed, 6 insertions(+), 2 deletions(-)
> >
> >Applied, thanks.
>
> Hmm... probably it was too early to apply this? I was just going
> to prepare v2, based on discussion...

Which discussion?

> Also, applying only 11/21, without 01/21, will just cause build errors ...

CC'ing me on this patch alone when you know you have build
dependencies on other patches in the set is a bad idea. Failing to
mention that you wanted the patch to be handled in a special and/or
unconventional way is an even worse idea.

How are you expecting this patch(-set) to be handled?

> Confused.

Likewise!

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/