Re: [PATCH] mm: slab.h: wrap the whole file with guarding macro

From: David Rientjes
Date: Wed Jun 18 2014 - 16:22:41 EST


On Wed, 18 Jun 2014, Andrey Ryabinin wrote:

> Guarding section:
> #ifndef MM_SLAB_H
> #define MM_SLAB_H
> ...
> #endif
> currently doesn't cover the whole mm/slab.h. It seems like it was
> done unintentionally.
>
> Wrap the whole file by moving closing #endif to the end of it.
>
> Signed-off-by: Andrey Ryabinin <a.ryabinin@xxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Looks like

ca34956b804b ("slab: Common definition for kmem_cache_node")
e25839f67948 ("mm/slab: Sharing s_next and s_stop between slab and slub
276a2439ce79 ("mm/slab: Give s_next and s_stop slab-specific names")

added onto the header without the guard and it has been this way since
Jan 10 2013. Andrey, how did you notice that this was an issue? Simply
by visual inspection?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/