Re: [PATCH v4 0/4] perf timechart io mode

From: Namhyung Kim
Date: Tue Jun 24 2014 - 02:43:53 EST


Hi Stanislav,

On Fri, 20 Jun 2014 14:29:47 +0400, Stanislav Fomichev wrote:
> This patchset adds IO mode: instead of process time we record io syscalls
> and then draw timechart of writes/reads/tx/rx/polls.

Nice work! For the series,

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung


>
> v4:
> - another attempt for fix segfault when skipping invalid tracepoints
> - added new patch to fix rendering in Firefox
>
> v3:
> - fixed segfault when skipping invalid tracepoints
> - added ms/us units support for --io-xyz time options
> - fixed missing boxes on Firefox
>
> v2:
> - separated start_time fix into distinct commit
> - separated --io-xyz options into distinct commit
> - fixed 'error' shadowing
> - initialized variables in declaration when possible
> - removed assert usage
> - fprintf -> pr_err
> - removed wrongly placed __maybe_unused
>
> Stanislav Fomichev (4):
> perf timechart: fix rendering in Firefox
> perf timechart: implement IO mode
> perf timechart: conditionally update start_time on fork
> perf timechart: add more options to IO mode
>
> tools/perf/Documentation/perf-timechart.txt | 38 +-
> tools/perf/builtin-timechart.c | 686 +++++++++++++++++++++++++++-
> tools/perf/util/svghelper.c | 168 +++++--
> tools/perf/util/svghelper.h | 6 +-
> 4 files changed, 838 insertions(+), 60 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/