Re: [PATCHv2 6/6] mm/zpool: prevent zbud/zsmalloc from unloading when used

From: Dan Streetman
Date: Tue Jun 24 2014 - 11:42:03 EST


On Mon, Jun 23, 2014 at 5:48 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 2 Jun 2014 18:19:46 -0400 Dan Streetman <ddstreet@xxxxxxxx> wrote:
>
>> Add try_module_get() to zpool_create_pool(), and module_put() to
>> zpool_destroy_pool(). Without module usage counting, the driver module(s)
>> could be unloaded while their pool(s) were active, resulting in an oops
>> when zpool tried to access them.
>
> Was wondering about that ;) We may as well fold
> this fix into "mm/zpool: implement common zpool api to zbud/zsmalloc"?

Yes. Sorry, I had this pulled out of that because I was trying to
keep the patches logically separated. But they do need to be
together, to be safe ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/