Re: [PATCH v2 REBASED 06/10] serial/arc: remove last remanants of platform data

[Vineet Gupta]

On Wednesday 25 June 2014 02:31 AM, Rob Herring wrote:
> On Tue, Jun 24, 2014 at 3:25 AM, Vineet Gupta
> <Vineet.Gupta1@xxxxxxxxxxxx> wrote:
>> Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
>> ---
>>  drivers/tty/serial/arc_uart.c | 22 ++++++----------------
>>  1 file changed, 6 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
>> index 2ffaf099691a..dc3d5db37dc4 100644
>> --- a/drivers/tty/serial/arc_uart.c
>> +++ b/drivers/tty/serial/arc_uart.c
>
>> @@ -518,21 +516,13 @@ arc_uart_init_one(struct platform_device *pdev, int dev_id)
>>         }
>>         uart->baud = val;
>>
>> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -       if (!res)
>> -               return -ENODEV;
>> -
>> -       res2 = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>> -       if (!res2)
>> -               return -ENODEV;
>> -
>> -       port->mapbase = res->start;
>> -       port->membase = ioremap_nocache(res->start, resource_size(res));
>> +       port->membase = of_iomap(np, 0);
> ioremap is preferred over of_iomap as it is not OF specific.

I could, but much of the driver assumes OF to be selected already (of_property...)

>  Perhaps
> use devm_request_and_ioremap instead.

devm_request_and_ioremap has been flag day removed in favour of
devm_ioremap_resource().
However even then it would require me to retain the prior platform_get_resource()
call.
IMHO, of_iomap is must more concise.

>
>>         if (!port->membase)
>>                 /* No point of dev_err since UART itself is hosed here */
>>                 return -ENXIO;
>>
>> -       port->irq = res2->start;
>> +       port->irq = irq_of_parse_and_map(np, 0);
>> +
> platform_get_irq should be used here.

And this again is for reducing OF dependency or is it something else.

Thx,
-Vineet

>
>>         port->dev = &pdev->dev;
>>         port->iotype = UPIO_MEM;
>>         port->flags = UPF_BOOT_AUTOCONF;
>> --
>> 1.8.3.2
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/