Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

From: Ezequiel García
Date: Thu Jun 26 2014 - 12:37:58 EST


On 26 Jun 12:02 PM, Guido Martínez wrote:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Martínez <guido@xxxxxxxxxxxxxxxxxxxx>

Just a nit: the commit title doesn't match the recent commits. If you
run "git log" on this file, you'll find the pattern should be something
like:

"ARM: OMAP2+: GPMC should only probe enabled devices"

Other than this, the patch looks correct.

Thanks,
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/