Re: [PATCH] rsxx: fix discard with length smaller than hw blksize

From: Jens Axboe
Date: Mon Jun 30 2014 - 17:06:32 EST


On 2014-06-30 11:31, Thadeu Lima de Souza Cascardo wrote:
When the discard length is not a multiple of RSXX_HW_BLK_SIZE, the
discard code will get into an infinite loop, even discarding data it is
not supposed to. This will also hang the system.

This can be reproduced by doing an ioctl BLKDISCARD to /dev/rsxx0 with
range from 0 to 1024.

That is a bug that should be fixed in the discard code, not worked around in the driver.


--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/