Re: [PATCH v3 5/9] slab: introduce alien_cache

From: Joonsoo Kim
Date: Tue Jul 01 2014 - 20:43:14 EST


On Tue, Jul 01, 2014 at 03:15:47PM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote:
>
> > -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp)
> > +static struct alien_cache *__alloc_alien_cache(int node, int entries,
> > + int batch, gfp_t gfp)
> > +{
> > + int memsize = sizeof(void *) * entries + sizeof(struct alien_cache);
>
> nit: all five memsizes in slab.c have type `int'. size_t would be more
> appropriate.
>

Hello,

As my inspection, there are 4 memsize. Can you confirm that?
Anyway, here goes the patch you suggested.

Thanks.

----------8<-----------------