Re: [PATCH] ipv4: icmp: Fix pMTU handling for rare case

From: Edward Allcutt
Date: Wed Jul 02 2014 - 05:05:28 EST


On Tue, 1 Jul 2014, David Miller wrote:
I still think the OpenBSD thing can't be intentional, and it's some
bug they probably want to fix and it should therefore be investigated.

Shout at me if this is getting too off-topic..

Looking at the 5.5 kernel, the plumbing to set up icp->icmp_nextmtu is all there in icmp_do_error() when it is passed a non-zero destmtu. ip_forward() seems to be the relevant caller, however this initializes destmtu to 0 and only sets it in the ICMP_UNREACH_NEEDFRAG case if both
#ifdef IPSEC and some conditional on the current route which I don't understand.

Either way it doesn't look intentional since the code to set it is present.

--
Edward Allcutt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/