Re: [PATCH 49/50] mars: generic pre-patch for mars

From: Christoph Hellwig
Date: Wed Jul 02 2014 - 10:50:32 EST


On Wed, Jul 02, 2014 at 04:36:42PM +0200, Thomas Sch?bel-Theuer wrote:
> However, I probably would have to "borrow" large parts of the
> sys_rmdir() implementation from fs/namei.c (the only real difference
> appears to me that the pathname is not in userspace).
>
> So, what is worse: copying relatively large pieces of code, or using
> sys_rmdir()?

Most likely you shouldn't do either. A block driver really should not
be removing directories from the filesystem namespace.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/