Re: [PATCH 1/5] mfd: Add DT bindings for tps65218 PMIC

[Felipe Balbi]

Hi,

On Thu, Jul 03, 2014 at 07:14:58PM +0530, Keerthy wrote:
> Add DT bindings for tps65218 PMIC
> 
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/tps65218.txt |   57 ++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt b/Documentation/devicetree/bindings/mfd/tps65218.txt
> new file mode 100644
> index 0000000..38f48ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
> @@ -0,0 +1,57 @@
> +Texas Instruments TPS65218 family
> +
> +The TPS65218 are Integrated Power Management Chips.
> +
> +Required properties:
> +- compatible : Must be "ti,tps65218";
> +  For Integrated power-management used in AM437x based boards
> +- interrupts : This i2c device has an IRQ line connected to the main SoC
> +- interrupt-controller : Since the tps65218 supports several interrupts
> +  internally, it is considered as an interrupt controller cascaded to the
> +  SoC one.
> +- #interrupt-cells = <2>;
> +- interrupt-parent : The parent interrupt controller which is gic.
> +
> +Optional node:
> +- TPS65218 PMIC has a number of child nodes. Mainly the regularors and SMPSs.
> +
> +Example:
> +/*
> + * Integrated Power Management Chip
> + */
> +tps65218: tps65218@24 {
> +	reg = <0x24>;
> +	compatible = "ti,tps65218";
> +	interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
> +	interrupt-parent = <&gic>;
> +	interrupt-controller;
> +	#interrupt-cells = <2>;
> +
> +	dcdc1: regulator-dcdc1 {
> +		compatible = "ti,tps65218-dcdc1";
> +		/* VDD_CORE voltage limits min of OPP50 and max of OPP100 */

wonder if this comment really makes sense here as boards might have
another regulator assignment. Likewise fro the other two regulators.
Also, this device provides 7 regulated outputs according to [1], why
only provide three here ?

[1] http://www.ti.com/product/tps65218

-- 
balbi

Attachment: signature.asc
Description: Digital signature