Re: [PATCH] thunderbolt: Correct the size argument to devm_kzalloc

From: Julia Lawall
Date: Mon Jul 07 2014 - 00:32:31 EST




On Sun, 6 Jul 2014, Greg KH wrote:

> On Sun, Jul 06, 2014 at 09:43:42PM +0530, Himangi Saraogi wrote:
> > nhi->rx_rings does not have type as struct tb_ring *, as it is a
> > double pointer so the elements of the array should have pointer type,
> > not structure type.
> >
> > The Coccinelle semantic patch that makes this change is as follows:
> >
> > // <smpl>
> > @disable sizeof_type_expr@
> > type T;
> > T **x;
> > @@
> >
> > x =
> > <+...sizeof(
> > - T
> > + *x
> > )...+>
> > // </smpl>
> >
> > Signed-off-by: Himangi Saraogi <himangi774@xxxxxxxxx>
> > Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> > ---
> > drivers/thunderbolt/nhi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Any reason you didn't cc: the developers in charge of this code so they
> see it and can pick it up? Otherwise it's just going to float around on
> the mailing list, listless and sad.

They don't seem to be in the MAINTAINERS file.

Himangi, you would see some people if you drop the --nogit-fallback
argument from get_maintainers. Maybe that is too strict.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/