[PATCH 74/83] hsa/radeon: Adding some error messages

From: Oded Gabbay
Date: Thu Jul 10 2014 - 17:59:37 EST


From: Ben Goz <ben.goz@xxxxxxx>

Signed-off-by: Ben Goz <ben.goz@xxxxxxx>
Signed-off-by: Oded Gabbay <oded.gabbay@xxxxxxx>
---
drivers/gpu/hsa/radeon/kfd_chardev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/hsa/radeon/kfd_chardev.c b/drivers/gpu/hsa/radeon/kfd_chardev.c
index 09c9a61..be89d26 100644
--- a/drivers/gpu/hsa/radeon/kfd_chardev.c
+++ b/drivers/gpu/hsa/radeon/kfd_chardev.c
@@ -137,11 +137,15 @@ kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p, void __user *a
if (copy_from_user(&args, arg, sizeof(args)))
return -EFAULT;

- if (!access_ok(VERIFY_WRITE, args.read_pointer_address, sizeof(qptr_t)))
+ if (!access_ok(VERIFY_WRITE, args.read_pointer_address, sizeof(qptr_t))) {
+ pr_err("kfd: can't access read pointer");
return -EFAULT;
+ }

- if (!access_ok(VERIFY_WRITE, args.write_pointer_address, sizeof(qptr_t)))
+ if (!access_ok(VERIFY_WRITE, args.write_pointer_address, sizeof(qptr_t))) {
+ pr_err("kfd: can't access write pointer");
return -EFAULT;
+ }

q_properties.is_interop = false;
q_properties.queue_percent = args.queue_percentage;
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/