Re: [PATCH v4 4/4] staging: rtl8192u: Fixed too long line

From: Greg KH
Date: Thu Jul 10 2014 - 18:11:44 EST


On Thu, Jul 10, 2014 at 05:54:57PM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@xxxxxxxxxx>
>
> This patch will fix too long lines warning
> reported by checkpatch.pl.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@xxxxxxxxxx>
> ---
> drivers/staging/rtl8192u/r819xU_phy.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
> index 3155616..b2d81e9 100644
> --- a/drivers/staging/rtl8192u/r819xU_phy.c
> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
> @@ -1236,7 +1236,8 @@ static u8 rtl8192_phy_SetSwChnlCmdArray(SwChnlCmd *CmdTable, u32 CmdTableIdx,
> return false;
> }
> if (CmdTableIdx >= CmdTableSz) {
> - RT_TRACE(COMP_ERR, "%s(): Access invalid index, please check size of the table, CmdTableIdx:%d, CmdTableSz:%d\n",
> + RT_TRACE(COMP_ERR,
> + "%s():invalid index,CmdTableIdx:%d, CmdTableSz:%d\n",

Why did you change the string? That's not ok, you can ignore this
warning, it's a string that you can not break up, or change.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/