Re: [PATCH 0/4 V3] irqchip: gic: Introduce ARM GICv2m MSI(-X) support

From: Jason Cooper
Date: Sun Jul 13 2014 - 19:15:10 EST


Suravee,

On Wed, Jul 09, 2014 at 06:05:00PM -0500, suravee.suthikulpanit@xxxxxxx wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
>
> This patch set introduces support for MSI(-X) in GICv2m specification,
> which is implemented in some variation of GIC400.
>
> This depends on and has been tested with the V7 of"Add support for PCI in AArch64"
> (https://lkml.org/lkml/2014/3/14/320).

Grrr. I mis-spoke against your v1 of this series. There are more
changes to irq-gic.c than I originally thought in this series.

Additionally, we have a lot of other significant changes to that driver
as well this cycle. It would be really helpful if I could take patches
1-3 through irqchip/gic. I can Ack #4 with the Subject change, and the
branch it lands in can depend on irqchip/gic, no problem there.

My main concern is your statement above and your answer to my inquiry
against v1.

Right now, I'm only concerned about breaking the build. Can I take 1-3?
Or, do we need to wait until aarch64 PCI lands in mainline?

If I can take them, I'll fix up the commit log of the one patch when I
apply them.

thx,

Jason.

> Changes in V3:
> * Rebase to git://git.infradead.org/users/jcooper/linux.git irqchip/gic
> (per Jason Cooper request)
> * Misc fix/clean up per Mark Rutland comments
> * Minor Clean up in the driver/irqchip/irq-gic-v2m.c: alloc_msi_irqs()
> * Patch 4 is new to the series:
> * Add ARM64-specific version arch_setup_msi_irqs() to allow support
> for Multiple MSI.
> * Add support for Multiple MSI for GICv2m.
>
> Suravee Suthikulpanit (4):
> irqchip: gic: Add binding probe for ARM GIC400
> irqchip: gic: Restructuring ARM GIC code
> irqchip: gic: Add supports for ARM GICv2m MSI(-X)
> irqchip: gicv2m: Add support for multiple MSI for ARM64 GICv2m
>
> Documentation/devicetree/bindings/arm/gic.txt | 20 +-
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/msi.h | 15 ++
> arch/arm64/kernel/Makefile | 1 +
> arch/arm64/kernel/msi.c | 57 +++++
> drivers/irqchip/Kconfig | 7 +
> drivers/irqchip/Makefile | 1 +
> drivers/irqchip/irq-gic-v2m.c | 331 ++++++++++++++++++++++++++
> drivers/irqchip/irq-gic-v2m.h | 13 +
> drivers/irqchip/irq-gic.c | 90 ++++---
> drivers/irqchip/irq-gic.h | 67 ++++++
> 11 files changed, 562 insertions(+), 41 deletions(-)
> create mode 100644 arch/arm64/include/asm/msi.h
> create mode 100644 arch/arm64/kernel/msi.c
> create mode 100644 drivers/irqchip/irq-gic-v2m.c
> create mode 100644 drivers/irqchip/irq-gic-v2m.h
> create mode 100644 drivers/irqchip/irq-gic.h
>
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/