Re: [PATCH -mm v5 12/13] mm: /proc/pid/clear_refs: avoid split_huge_page()

From: Cyrill Gorcunov
Date: Mon Jul 14 2014 - 02:40:32 EST


On Fri, Jul 11, 2014 at 02:35:48PM -0400, Naoya Horiguchi wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> Currently pagewalker splits all THP pages on any clear_refs request. It's
> not necessary. We can handle this on PMD level.
>
> One side effect is that soft dirty will potentially see more dirty memory,
> since we will mark whole THP page dirty at once.
>
> Sanity checked with CRIU test suite. More testing is required.
>
> ChangeLog:
> - move code for thp to clear_refs_pte_range()
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Cc: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxx>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
> Cc: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/