Re: [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues

From: Greg KH
Date: Tue Jul 15 2014 - 11:04:55 EST


On Mon, Jul 14, 2014 at 09:15:28PM +0200, Peter Senna Tschudin wrote:
> This patch cleans up the following checkpatch issues:
> - tabs instead of spaces on the beginning of a line
> - use correct /* */ comment style
> - put { and } on the correct places
> - line over 80 chars
> - indentation style for multi-line calls / comments
> - space after semicolon ,
> - new line after declaration
>
> Tested by compilation only.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
> ---
> Cahnges from V3:
> - Splitted the patches by change type

That's a lot of things to be doing all in one single patch, why didn't
you split this up further?

Please do so.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/