Re: [PATCH 04/19] serial: samsung: Remove support for legacy clock code

From: Tomasz Figa
Date: Wed Jul 16 2014 - 08:44:39 EST


On 16.07.2014 11:27, Paul Bolle wrote:
> On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote:
>> All Samsung platforms are now using the Common Clock Framework and the
>> legacy clock code is being removed, so remove related dead code from
>> samsung-serial driver as well.
>>
>> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (maintainer:SERIAL DRIVERS)
>> Cc: Jiri Slaby <jslaby@xxxxxxx> (supporter:TTY LAYER)
>> Cc: linux-serial@xxxxxxxxxxxxxxx (open list:SERIAL DRIVERS)
>> ---
>> drivers/tty/serial/samsung.c | 4 ----
>> 1 file changed, 4 deletions(-)
>
> This just entered linux-next (see next-20140716).
>
>> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>> index 36c7747..cae8ebd 100644
>> --- a/drivers/tty/serial/samsung.c
>> +++ b/drivers/tty/serial/samsung.c
>> @@ -47,10 +47,6 @@
>>
>> #include <asm/irq.h>
>>
>> -#ifdef CONFIG_SAMSUNG_CLOCK
>> -#include <plat/clock.h>
>> -#endif
>> -
>> #include "samsung.h"
>>
>> #if defined(CONFIG_SERIAL_SAMSUNG_DEBUG) && \
>
> There are three further references to CONFIG_SAMSUNG_CLOCK in this file.
> Those should be removed too, shouldn't they?

That's right. Apparently I missed them. I guess that's not critical,
though, and could be done in separate patch, right?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/