Re: [PATCH 4/4] mips: dma: Add cma support

From: Michal Nazarewicz
Date: Wed Jul 16 2014 - 12:39:19 EST


On Wed, Jul 16 2014, Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx> wrote:
> Adds cma support to the mips architecture.
>
> cma uses memblock. However, mips uses bootmem.

Does cma_early_percent_memory work correctly then?

> bootmem is informed about any regions reserved by memblock

Alternatively maybe it would make sense to create a new definition of
dma_contiguous_reserve_area that uses bootmem and choose it based on
some CONFIG_CMA_USE_BOOTMEM which would be selected by MIPS.

> dma api is modified to use cma reserved memory regions when available
>
> Tested using cma_test. cma_test is a simple driver that assigns blocks
> of memory from cma reserved sections.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
> arch/mips/Kconfig | 1 +
> arch/mips/include/asm/Kbuild | 1 +
> arch/mips/kernel/setup.c | 9 +++++++++
> arch/mips/mm/dma-default.c | 37 +++++++++++++++++++++++++------------
> 4 files changed, 36 insertions(+), 12 deletions(-)
>

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/