Re: [PATCH] staging: gdm72xx: conditionally compile debug code

[Michalis Pappas]

On 07/09/2014 07:51 PM, Greg KH wrote:
>> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c
>> index 9d2de6f..914fd75 100644
>> --- a/drivers/staging/gdm72xx/gdm_sdio.c
>> +++ b/drivers/staging/gdm72xx/gdm_sdio.c
>> @@ -280,9 +280,11 @@ static void send_sdu(struct sdio_func *func, struct tx_cxt *tx)
>>  
>>  	spin_unlock_irqrestore(&tx->lock, flags);
>>  
>> +	#if defined(GDM72xx_DEBUG)
>>  	print_hex_dump_debug("sdio_send: ", DUMP_PREFIX_NONE, 16, 1,
>>  			     tx->sdu_buf + TYPE_A_HEADER_SIZE,
>>  			     aggr_len - TYPE_A_HEADER_SIZE, false);
>> +	#endif
> 
> This should be moved to use dev_dbg(), along with the other calls to
> this function in this file.
> 

But dev_dbg() gets eventually to be printk(), which cannot print the
buffer, so using print_hex_dump_debug() seems to be correct for this
case, no?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/