Re: [PATCH v3 0/7] i2c: Relax mandatory I2C ID table passing

From: Lee Jones
Date: Thu Jul 17 2014 - 06:23:56 EST


Hi Wolfram,

Are you going to take a lot at this set?

> As previously discussed I believe it should be okay for an I2C device
> driver _not_ supply an I2C ID table to match to. The I2C subsystem
> should be able to match via other means, such as via OF tables. The
> blocking factor during our previous conversation was to keep
> registering via sysfs up and running. This set does that.
>
> After thinking more deeply about the problem, it occurred to me that
> any I2C device driver which uses the sysfs method and issues an
> of_match_device() would also fail their probe(). Bolted on to this
> set is a new, more generic way for these devices to match against
> either of the I2C/OF tables.
>
> I hope this ticks all of your boxes.
>
> v3:
> - Insist on passing 'struct i2c_client' instead of 'struct device'
> - Remove hook from of_match_device()
>
> v2:
> - Removal of ACPI support (this is really an OF issue).
> - Add a new .probe2( with will seamlessly replace
> - Supply a warning on devices matching via OF without a suitable compatible
> - Remove unified match_device() - bad idea as it subverts type-safe behaviour
> - Provide examples of the kind of clean-up possible after this set.
> - I already have the full support from the maintainer of these drivers =;-)
>
> Kind regards,
> Lee
>
> arch/arm/configs/multi_v7_defconfig | 1 +
> drivers/i2c/i2c-core.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
> drivers/mfd/88pm860x-core.c | 5 ++---
> drivers/mfd/as3722.c | 12 ++----------
> include/linux/i2c.h | 22 +++++++++++++++++++++-
> 5 files changed, 89 insertions(+), 23 deletions(-)
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/