Re: [PATCH 1/1 V2] workqueue: unfold start_worker() into create_worker()

From: Tejun Heo
Date: Fri Jul 18 2014 - 18:57:25 EST


Sorry about the delay.

On Wed, Jul 16, 2014 at 09:28:55AM +0800, Lai Jiangshan wrote:
> On 07/14/2014 12:05 PM, Lai Jiangshan wrote:
> > Simply unfold the code of start_worker() into create_worker() and
> > remove the original start_worker() and create_and_start_worker().
> >
> > The only trade-off is the introduced overhead that the pool->lock
> > is released and re-grabbed after the newly worker is started.
> > The overhead is acceptable since the manager is slow path.
>
> Hi, TJ
>
> Will you accept this trade-off and the patch?
> If so, I will rebase this patch without any dependence on other patch.

Yeap, that's fine.

Thanks!

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/