Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

[Ethan Zhao]

在 2014年7月19日，上午2:21，Rajesh Borundia <rajesh.borundia@xxxxxxxxxx> 写道：

>> -----Original Message-----
>> From: Ethan Zhao [mailto:ethan.zhao@xxxxxxxxxx]
>> Sent: Friday, July 18, 2014 9:13 AM
>> To: Manish Chopra; Sony Chacko; Rajesh Borundia; netdev
>> Cc: linux-kernel; ethan.kernel@xxxxxxxxx; Ethan Zhao
>> Subject: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool
>> get_ethtool_stats()
>> 
>> netxen driver has implemented netxen_nic_get_ethtool_stats() interface,
>> but it doesn't collect stats.rxdropped in driver, so we will get different
>> rx_dropped statistic information while using ifconfig and ethtool.
>> this patch fills stats.rxdropped field with data from net core with
>> dev_get_stats() just as ixgbe driver did for some of its stats.
> 
> I think ethtool stats are adapter specific. Driver does not maintain
> rx_dropped stats and we also don't get it from adapter.  I am not
> sure if ethtool stats should match ifconfig stats as ifconfig also
> adds net core stats to adapter stats.
I held the same point as yours before I read more drivers implementation under
Ethernet dir, in fact there is no specification/convention that ethtool info is adapter
Specific. All information output by ethtool is based on the information name itself,
One fact we want this patch is netxen defined 'rx dropped' field but output nothing.

> 
> If ethtool stats should report same values as ifconfig stats then
> we may also need to fix tx_dropped statistics.
> 
at least, tx dropped output information... 

Thanks,
Ethan
> Thanks,
> Rajesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/