staging/8821ae driver breaks allyes build in 3.16-rc*

From: Andi Kleen
Date: Sun Jul 20 2014 - 15:05:29 EST

Next message: Jonathan Cameron: "Re: [PATCH v7 0/4] iio: Add support for rotation from north"
Previous message: Sam Ravnborg: "Re: [PATCH 1/2] kbuild: Support split debug info v3"
Next in thread: Greg KH: "Re: staging/8821ae driver breaks allyes build in 3.16-rc*"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

I cannot build make allyesconfig in current Linus mainline, because
drivers/staging/rtl8821ae has a lot of compile errors.

I tried to fix some, but it seems to be wide spread and sometimes
non obvious.

It may be related to the following series from Sachin,
however when just reverting those the driver gains some new
unrelated compile errors. It may be still a good idea
to revert those because the earlier errors are likely
easier to fix. Or just disable the driver until it at least
builds.

Please fix it in some way, allyesconfig should build!

fe6d68f staging: rtl8821ae: stats.c: Remove version specific code
2b4b5a6 staging: rtl8821ae: trx.h: Remove version specific code
e7f5a21 staging: rtl8821ae: trx.c: Remove version specific code
575e8da staging: rtl8821ae: sw.c: Remove version specific code
0c288d4 staging: rtl8821ae: regd.h: Remove version specific code
b9ddcee staging: rtl8821ae: regd.c: Remove version specific code
756a748 staging: rtl8821ae: rc.c: Remove version specific code
35722b4 staging: rtl8821ae: ps.c: Remove version specific code
aa59f7a staging: rtl8821ae: pci.h: Remove version specific code
c6e8a9e staging: rtl8821ae: pci.c: Remove version specific code
1939f35 staging: rtl8821ae: efuse.c: Remove version specific code
4874043 staging: rtl8821ae: debug.c: Remove version specific code
0cd05ba staging: rtl8821ae: core.c: Remove version specific code
4797740 staging: rtl8821ae: compat.h: Remove version specific code
80e3e09 staging: rtl8821ae: cam.c: Remove version specific code
8b292b0 staging: rtl8821ae: base.c: Remove version specific code

Errors with series reverted:

In file included from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c:21:
/home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/../pci.h:289:15: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before ârtl_pci_probeâ
int __devinit rtl_pci_probe(struct pci_dev *pdev,
^
In file included from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/efuse.c:31:
/home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/../pci.h:289:15: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before ârtl_pci_probeâ
int __devinit rtl_pci_probe(struct pci_dev *pdev,
^
make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.o] Error 1
CC [M] drivers/staging/rtl8821ae/rtl8821ae/table.o
In file included from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/rtl_btc.h:32,
from /home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/ps.c:36:
/home/ak/lsrc/git/linux-2.6/drivers/staging/rtl8821ae/btcoexist/../pci.h:289:15: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before ârtl_pci_probeâ
int __devinit rtl_pci_probe(struct pci_dev *pdev,
^
make[3]: *** [drivers/staging/rtl8821ae/efuse.o] Error 1

Errors in mainline:

make[1]: Entering directory `/home/ak/lsrc/git/obj-allyes'
CC [M] drivers/staging//rtl8821ae/base.o
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c: In function ârtl_send_smps_actionâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c:1455:3: warning: passing argument 2 of ârtlpriv->intf_ops->adapter_txâ from incompatible pointer type [enabled by default]
rtlpriv->intf_ops->adapter_tx(hw, sta, skb, &tcb_desc);
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c:1455:3: note: expected âstruct sk_buff *â but argument is of type âstruct ieee80211_sta *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c:1455:3: warning: passing argument 3 of ârtlpriv->intf_ops->adapter_txâ from incompatible pointer type [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c:1455:3: note: expected âstruct rtl_tcb_desc *â but argument is of type âstruct sk_buff *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/base.c:1455:3: error: too many arguments to function ârtlpriv->intf_ops->adapter_txâ
make[4]: *** [drivers/staging//rtl8821ae/base.o] Error 1
CC [M] drivers/staging//rtl8821ae/core.o
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c: In function ârtl_op_txâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:107:2: warning: passing argument 2 of ârtlpriv->intf_ops->waitq_insertâ from incompatible pointer type [enabled by default]
if (!rtlpriv->intf_ops->waitq_insert(hw, control->sta, skb))
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:107:2: note: expected âstruct sk_buff *â but argument is of type âstruct ieee80211_sta *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:107:2: error: too many arguments to function ârtlpriv->intf_ops->waitq_insertâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:108:10: warning: passing argument 2 of ârtlpriv->intf_ops->adapter_txâ from incompatible pointer type [enabled by default]
rtlpriv->intf_ops->adapter_tx(hw, control->sta, skb, &tcb_desc);
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:108:10: note: expected âstruct sk_buff *â but argument is of type âstruct ieee80211_sta *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:108:10: warning: passing argument 3 of ârtlpriv->intf_ops->adapter_txâ from incompatible pointer type [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:108:10: note: expected âstruct rtl_tcb_desc *â but argument is of type âstruct sk_buff *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:108:10: error: too many arguments to function ârtlpriv->intf_ops->adapter_txâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c: In function ârtl_op_flushâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/core.c:1288:3: error: too many arguments to function ârtlpriv->intf_ops->flushâ
rtlpriv->intf_ops->flush(hw, queues, drop);
^
make[4]: *** [drivers/staging//rtl8821ae/core.o] Error 1
CC [M] drivers/staging//rtl8821ae/pci.o
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c: In function â_rtl_pci_tx_chk_waitqâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:570:4: warning: passing argument 3 of ârtlpriv->intf_ops->adapter_txâ from incompatible pointer type [enabled by default]
rtlpriv->intf_ops->adapter_tx(hw, NULL, skb, &tcb_desc);
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:570:4: note: expected âstruct rtl_tcb_desc *â but argument is of type âstruct sk_buff *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:570:4: error: too many arguments to function ârtlpriv->intf_ops->adapter_txâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c: In function â_rtl_pci_prepare_bcn_taskletâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1156:6: warning: passing argument 7 of ârtlpriv->cfg->ops->fill_tx_descâ makes integer from pointer without a cast [enabled by default]
BEACON_QUEUE, &tcb_desc);
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1156:6: note: expected âu8â but argument is of type âstruct sk_buff *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1156:6: warning: passing argument 8 of ârtlpriv->cfg->ops->fill_tx_descâ makes pointer from integer without a cast [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1156:6: note: expected âstruct rtl_tcb_desc *â but argument is of type âintâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1156:6: error: too many arguments to function ârtlpriv->cfg->ops->fill_tx_descâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c: In function ârtl_pci_txâ:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: warning: passing argument 6 of ârtlpriv->cfg->ops->fill_tx_descâ from incompatible pointer type [enabled by default]
hw_queue, ptcb_desc);
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: note: expected âstruct sk_buff *â but argument is of type âstruct ieee80211_sta *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: warning: passing argument 7 of ârtlpriv->cfg->ops->fill_tx_descâ makes integer from pointer without a cast [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: note: expected âu8â but argument is of type âstruct sk_buff *â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: warning: passing argument 8 of ârtlpriv->cfg->ops->fill_tx_descâ makes pointer from integer without a cast [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: note: expected âstruct rtl_tcb_desc *â but argument is of type âu8â
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:1693:6: error: too many arguments to function ârtlpriv->cfg->ops->fill_tx_descâ
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c: At top level:
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2422:2: warning: initialization from incompatible pointer type [enabled by default]
.adapter_tx = rtl_pci_tx,
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2422:2: warning: (near initialization for ârtl_pci_ops.adapter_txâ) [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2423:2: warning: initialization from incompatible pointer type [enabled by default]
.flush = rtl_pci_flush,
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2423:2: warning: (near initialization for ârtl_pci_ops.flushâ) [enabled by default]
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2425:2: warning: initialization from incompatible pointer type [enabled by default]
.waitq_insert = rtl_pci_tx_chk_waitq_insert,
^
/home/ak/lsrc/git/linux-2.6/drivers/staging//rtl8821ae/pci.c:2425:2: warning: (near initialization for ârtl_pci_ops.waitq_insertâ) [enabled by default]
make[4]: *** [drivers/staging//rtl8821ae/pci.o] Error 1
make[4]: Target `__build' not remade because of errors.
make[3]: *** [drivers/staging//rtl8821ae] Error 2
make[3]: Target `__build' not remade because of errors.
make[2]: *** [_module_drivers/staging/] Error 2
make[2]: Target `_all' not remade because of errors.
make[1]: *** [sub-make] Error 2
make[1]: Target `_all' not remade because of errors.
make: *** [__sub-make] Error 2

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Jonathan Cameron: "Re: [PATCH v7 0/4] iio: Add support for rotation from north"
Previous message: Sam Ravnborg: "Re: [PATCH 1/2] kbuild: Support split debug info v3"
Next in thread: Greg KH: "Re: staging/8821ae driver breaks allyes build in 3.16-rc*"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]