Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree

From: Matthew Longnecker
Date: Mon Jul 21 2014 - 19:13:01 EST


On 6/27/2014 1:11 AM, Mikko Perttunen wrote:
This adds the soctherm thermal sensing and management unit to the
Tegra124 device tree along with the four thermal zones it exports.

Mikko, soctherm doesn't "export thermal zones". I would rewrite your desription like this:

Extend the Tegra124 device tree by adding the soctherm thermal
sensing and management unit and by defining four thermal zones --
one for each temperature sensor in soctherm.

System integrators have some flexibility in deciding how many thermal zones to define for their platform. For example, an integrator could define a single zone for the entire Tegra chip (giving a simple system at runtime) or with multiple zones (giving potentially higher performance near thermal limits). That's why I don't like the implication that soctherm dictates the existence of particular thermal zones.

-Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/