Re: [PATCH V3] perf tools: Record whether a dso has data

From: Jiri Olsa
Date: Tue Jul 22 2014 - 03:55:50 EST


On Thu, Jul 17, 2014 at 11:58:30AM +0300, Adrian Hunter wrote:
> Add 'data_status' to record whether a dso has data
> (i.e. an object file)

I might have seen it in your last patsent, but forgot.. what is
this data_status going to be used for?

SNIP

> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
> index c239e86..07d0a58 100644
> --- a/tools/perf/util/dso.h
> +++ b/tools/perf/util/dso.h
> @@ -40,6 +40,12 @@ enum dso_swap_type {
> DSO_SWAP__YES,
> };
>
> +enum dso_data_status {
> + DSO_DATA_STATUS_ERROR = -1,
> + DSO_DATA_STATUS_UNKNOWN = 0,
> + DSO_DATA_STATUS_OK = 1,
> +};
> +
> #define DSO__SWAP(dso, type, val) \
> ({ \
> type ____r = val; \
> @@ -104,6 +110,7 @@ struct dso {
> struct {
> struct rb_root cache;
> int fd;
> + int data_status;

also please call it just 'status' it's already in 'data' struct

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/