Re: [PATCH 0/6 v2] PM / Hibernate: Memory bitmap scalability improvements

[Joerg Roedel]

On Tue, Jul 22, 2014 at 12:55:46PM +0200, Pavel Machek wrote:
> On Tue 2014-07-22 12:34:44, Joerg Roedel wrote:

> Writing out every single page on 12TB machine to disk does not scale,
> either :-).

But there is not much potential optimizing the write-out either (in
software). But that doesn't mean we shouldn't do the parts better that
we *can* do better.

> > I also see how the problem could be solved differently, but what I
> > didn't get from the discussion yet is: What is actually *wrong* with
> > *this* approach?
> 
> It throws complex / tricky to review code at a problem...

A radix tree implementation is neither tricky nor overly complex. Also,
if you have questions about particular parts of the implementation I am
happy to explain them/add a comment to make them more clear.

But all you did so far was looking for reasons why this change is bad,
and as that failed you went back to just question its usefulnes.

> that is not a problem in any reasonable configuration.

What is reasonable heavily depends on who you ask. Only if its not an
issue for you doesn't mean it isn't for anybody else. For our partner
the current situation is a real world problem and these patches fix
it.

> Now... should I spend half an hour reviewing your changes, or are we
> maybe better without them?

I bet you already spent more than half an hour discussing reasons with
me not to review this code.


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/