Re: [PATCH] drm/crtc-helper: use drm_framebuffer flags

From: Benjamin Gaignard
Date: Tue Jul 22 2014 - 11:40:38 EST


Adding LKML and David in diffusion list to get an opinion on this patch

2014-07-10 10:01 GMT+02:00 Fabien DESSENNE <fabien.dessenne@xxxxxx>:
> Hi,
> Can anyone review this patch ?
> Thanks for your time.
> Fabien
>
>> -----Original Message-----
>> From: Fabien DESSENNE [mailto:fabien.dessenne@xxxxxx]
>> Sent: mardi 1 juillet 2014 14:41
>> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE
>> Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags
>>
>> The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
>> propagated and used by the driver.
>> The only possible value of flags is DRM_MODE_FB_INTERLACED.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@xxxxxx>
>> Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@xxxxxx>
>> ---
>> drivers/gpu/drm/drm_crtc_helper.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
>> b/drivers/gpu/drm/drm_crtc_helper.c
>> index 23500c0..5974489 100644
>> --- a/drivers/gpu/drm/drm_crtc_helper.c
>> +++ b/drivers/gpu/drm/drm_crtc_helper.c
>> @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct
>> drm_framebuffer *fb,
>> drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
>> &fb->bits_per_pixel);
>> fb->pixel_format = mode_cmd->pixel_format;
>> + fb->flags = mode_cmd->flags;
>>
>> return 0;
>> }
>> --
>> 1.9.1
>



--
Benjamin Gaignard

Graphic Working Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/