Re: [PATCH] drbd: Remove fix me statements

[Nick Krause]

On Wed, Jul 23, 2014 at 8:27 AM, BjÃrn Mork <bjorn@xxxxxxx> wrote:
> Nicholas Krause <xerofoify@xxxxxxxxx> writes:
>
>> This removes no longer needed fix me statements
>
> If you claim that they no longer are needed then I expect you to explain
> what's changed since they were added.
>
>> as the spinlocks
>> are needed to protect against other users of the list accessing
>>  it when items on it are being moved off it.
>
> Yes, that's most likely why the locking is there.
>
> The FIXMEs on the other hand, are probably there to tell you that it
> would be nice to get rid of the double locking.  I don't see that
> changing.
>
>
> BjÃrn
>

Bjorn,
Can we remove the double locking  as you are stating or do  we still need it
to protect against the list being accessed  as the list seems to be moving
to a spinlock protected list.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/