Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup

[Chen, Gong]

On Wed, Jul 23, 2014 at 08:07:18PM +0200, Borislav Petkov wrote:
> Date: Wed, 23 Jul 2014 20:07:18 +0200
> From: Borislav Petkov <bp@xxxxxxxxx>
> To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, tglx@xxxxxxxxxxxxx,
>  paulus@xxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx,
>  hpa@xxxxxxxxx, jkosina@xxxxxxx, rafael.j.wysocki@xxxxxxxxx,
>  linux@xxxxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx,
>  davem@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, fweisbec@xxxxxxxxx,
>  cl@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, axboe@xxxxxxxxx,
>  JBottomley@xxxxxxxxxxxxx, neilb@xxxxxxx, christoffer.dall@xxxxxxxxxx,
>  rostedt@xxxxxxxxxxx, rric@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx,
>  mhocko@xxxxxxx, david@xxxxxxxxxxxxx
> Subject: Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> On Tue, Jul 22, 2014 at 09:58:48PM -0400, Chen, Gong wrote:
> > Remove XXX_FROZEN state from x86/pci/amd_bus.
> > 
> > Signed-off-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>
> > ---
> >  arch/x86/pci/amd_bus.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
> > index c20d2cc..30f0fca9 100644
> > --- a/arch/x86/pci/amd_bus.c
> > +++ b/arch/x86/pci/amd_bus.c
> > @@ -341,9 +341,8 @@ static int amd_cpu_notify(struct notifier_block *self, unsigned long action,
> >  			  void *hcpu)
> >  {
> >  	int cpu = (long)hcpu;
> > -	switch (action) {
> > +	switch (action & ~CPU_TASKS_FROZEN) {
> >  	case CPU_ONLINE:
> > -	case CPU_ONLINE_FROZEN:
> >  		smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
> >  		break;
> >  	default:
> 
> Or you can kill all the switch-case gunk and make it even more readable:
> 
But what if new action is added? We have to change it back. If you prefer
to use that style I can update in next version.

Attachment: signature.asc
Description: Digital signature