Re: [PATCH] staging: Change kzalloc to kcalloc

From: Steven Rostedt
Date: Thu Jul 24 2014 - 13:18:28 EST


On Thu, 24 Jul 2014 12:50:31 -0400
Nick Krause <xerofoify@xxxxxxxxx> wrote:

\
> > Most kernel devs most certainly did NOT get started by spamming lkml
> > with unnecessary and incorrect patches despite being repeatedly told to
> > go away and stop wasting everybody's time.

Mans, shut up! That is uncalled for.


> >
> > --
> > Måns Rullgård
> > mans@xxxxxxxxx
>
>
>
> FIne , I give up. You want me to leave this then I wiil.

No, that's not what I said.

> I am have this discussion with other kernel developers and just
> because I send out one patch as a newbie like this doesn't mean I
> don't known C.

It's not just one patch, and I didn't say you don't know C. I said you
don't understand C enough for kernel development.

Look, I really do like you enthusiasm, and I'm sorry that you are being
attacked the way you were. Some of the attacks are uncalled for, and I
even regret some of my own previous emails to you, as they too were
uncalled for. But I do not regret my reply in this thread.

I worked in various jobs for 6 years before touching the kernel. It was
2 years after that that I started doing trivial patches (fixing
off-by-one bugs and such). Then I started out doing real time
development outside of the mainline kernel for several more years
before I starting writing code for mainline.

That is, you don't just jump into kernel development before having a
solid foundation of programming skills.

The patch I replied to didn't just have a mistake. It really was wrong
on several levels that it couldn't be right. Getting such a simple patch
so wrong really shows that you need more experience.

Please, start working with some userspace projects first, where you can
easily walk through the code using gdb to understand how things work.
Spend a year or two doing that kind of work. There's even paying jobs
out there that require this. There's tons of opensource projects that
need help. The Linux kernel is really the biggest opensource project
and very intense. A "newbie" here means you haven't done much with the
kernel, but you have done a lot of coding in the past. It doesn't mean
"newbie" to development in general.

I've been told by my wife that I'm very blunt and say what's on my
mind. I'm not very tactful, as I hate beating around the bush. I hate
it when people beat around the bush with me, I usually just tell them to
"spit it out!" Thus, I treat people as I want to be treated, that is
"in-your-face truth".

Again, don't "go away" and never come back. "go away, learn a bit more,
then come back".

A lot of us are overworked and staring at code all day. We get grumpy,
and when someone comes along and starts spamming us with nonsense
changes, we sometimes bite back. Don't take it personally. I'm serious
when I say, just spend some time on userspace projects, then work you
way to some drivers, and then you can be more active, and more
importantly, more useful to the Linux kernel project :-)

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/