Re: [PATCH] staging: dgnc: remove commented code

From: Tobias Klauser
Date: Tue Jul 29 2014 - 05:19:27 EST


On 2014-07-25 at 18:49:01 +0200, Seunghun Lee <waydi1@xxxxxxxxx> wrote:
> This patch removes commented code in dgnc driver.
>
> CC: Lidza Louina <lidza.louina@xxxxxxxxx>
> CC: Mark Hounschell <markh@xxxxxxxxxx>
> Signed-off-by: Seunghun Lee <waydi1@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 5 +-
> drivers/staging/dgnc/dgnc_trace.c | 123 -------------------------------------
> drivers/staging/dgnc/dgnc_trace.h | 10 ---
> drivers/staging/dgnc/dgnc_tty.c | 18 ------
> drivers/staging/dgnc/digi.h | 1 -
> 5 files changed, 1 insertion(+), 156 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 8e265c2..4b65306 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1046,10 +1046,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
> * I believe this is a BUG in this UART.
> * So for now, we will leave the code #ifdef'ed out...
> */

The comment above relates to the deleted code, so it should be updated
accordingly.

> -#if 0
> - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
> - &ch->ch_cls_uart->isr_fcr);
> -#endif
> +
> udelay(10);
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/