Re: [PATCH] trace-cmd: add trace-record.o to the python shared lib

From: Josef Bacik
Date: Wed Jul 30 2014 - 12:13:10 EST


On 07/22/2014 08:58 AM, Johannes Berg wrote:
On Mon, 2014-07-21 at 17:01 -0400, Steven Rostedt wrote:
Cc'd my python gurus.

Acks?

When trying to use the python library it was giving me an error about not being
able to resolve tracecmd_stat_cpu. This is because we weren't linking
trace-record.o to ctracecmd.so. Fix this in the makefile and now I can import
trace-cmd in python properly. Thanks,

I guess, I don't see anything wrong with that. I don't usually use
ctracecmd.so standalone, only as part of trace-cmd, which may explain
why I didn't see any problem?


Maybe? I'm not sure how it worked for you, with just a normal install I can
load up python and import tracecmd and it blows up immediately. This is
pointing at the /usr/local/lib/trace-cmd/python stuff, not using it from
trace-cmd directly. Steve can you take these two patches so I can close out my
internal stuff? I don't like carrying patches I can't point at an upstream
commit for. Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/