Re: [PATCH 2/2] serial: Add support for Fintek F81216A LPC to 4 UART

From: Ricardo Ribalda Delgado
Date: Thu Jul 31 2014 - 12:08:21 EST


Hello Alan

> Less than ideal in some ways because the base may well be remapped by
> other hardware or on non x86 devices. No obvious ideas how to fix it
> though and PnP kind of implies x86.

If I extend the driver to consider other hw than x86 and PnP I will
definitely look into this.

>
> On the bright side you can then make the resource layer do your locking
> work for you. We have an IORESOURCE_MUXED flag for these little horrors
> so you can request the resource with IORESOURCE_MUXED. If the resource is
> busy then you will get a failure back, if it is idle you will get the
> resource, if it is busy but held by another driver using IORESOURCE_MUXED
> then the request will block until they finish with it.

I was not aware of request_mutex, thanks for your help!. I am
preparing v2 with no mutex and requtest_mutex_region.

Thanks!

--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/