RE: [PATCH 15/18 v2] staging: comedi: amplc_pci224: put board indices in PCI driver_data

From: Hartley Sweeten
Date: Mon Aug 04 2014 - 12:38:38 EST


On Monday, August 04, 2014 4:14 AM, Ian Abbott wrote:
> The `driver_data` member value from the matched entry of the PCI module
> device table `amplc_pci224_pci_table[]` is passed through to our comedi
> "auto_attach" handler, `pci224_auto_attach()`. Use that to index
> directly into our static board data array `pci224_boards[]` instead of
> calling `pci224_find_pci_board()` to search for the entry matching the
> PCI device ID. That function can be removed. The `devid` and `model`
> members of `struct pci224_board` are no longer needed either and can be
> removed.
>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> ---
> v2: Use C99 syntax for amplc_pci224_pci_table[] initializer. Thanks to
> Hartley for finding that!

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

Thanks,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/