Re: [PATCH 1/3] tty: serial: 8250: Add new capability for highspeed register

From: One Thousand Gnomes
Date: Tue Aug 05 2014 - 07:45:48 EST


>
> /*
> + * Mediatek UARTs use an extra highspeed register (UART_MTK_HIGHS)
> + *
> + * We need to recalcualte the quot register, as the claculation depends
> + * on the vaule in the highspeed register.
> + *
> + * Some baudrates are not supported by the chip, so we use the next
> + * lower rate supported.
> + *
> + * If highspeed register is set to 3, we need to specify sample count
> + * and sample point to increase accuracy. If not, we reset the
> + * registers to their default values.
> + */

Don't put stuff in the core driver core for your chip specific weirdness,
wrap the termios method with your own in your driver code as a fair
number of other 8250ish drivers do.

If you do that then you don't need to waste a UART CAPS flag and you
don't need to put anything in the core driver code.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/