RE: [PATCH net-next] hyperv: Increase the buffer length for netvsc_channel_cb()

From: Haiyang Zhang
Date: Tue Aug 05 2014 - 16:13:33 EST




> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Tuesday, August 5, 2014 4:04 PM
> To: thomas1206@xxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; Haiyang Zhang; KY Srinivasan; olaf@xxxxxxxxx;
> jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
> devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next] hyperv: Increase the buffer length for
> netvsc_channel_cb()
>
> From: Haiyang Zhang <thomas1206@xxxxxxxxx>
> Date: Fri, 1 Aug 2014 15:55:30 +0000
>
> > When the buffer is too small for a packet from VMBus, a bigger buffer
> will be
> > allocated in netvsc_channel_cb() and retry reading the packet from
> VMBus.
> > Increasing this buffer size will reduce the retry overhead.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
>
> I'm not applying this, sorry.
>
> I said that because the structure that contains this buffer is now
> larger than a page, you should allocate the CB buffer externally
> via another kmalloc() or via the page allocator.

This must have been re-sent accidentally when we are updating our
Email server... I will update the patch and re-submit it soon.

Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/