Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

From: Mark Brown
Date: Thu Aug 07 2014 - 05:46:02 EST


On Tue, Aug 05, 2014 at 03:32:05PM +0800, Nicolin Chen wrote:
> From: Nicolin Chen <Guangyu.Chen@xxxxxxxxxxxxx>
>
> SAI supports these operation modes:
> 1) asynchronous mode
> Both Tx and Rx are set to be asynchronous.
> 2) synchronous mode (Rx sync with Tx)
> Tx is set to be asynchronous, Rx is set to be synchronous.
> 3) synchronous mode (Tx sync with Rx)
> Rx is set to be asynchronous, Tx is set to be synchronous.
> 4) synchronous mode (Tx/Rx sync with another SAI's Tx)
> 5) synchronous mode (Tx/Rx sync with another SAI's Rx)

This seems to conflict with something else on my branch - not checked
what. Can you take a look please?

> +Note:
> +- If both fsl,sai-asynchronous and fsl,sai-synchronous-rx are absent, the
> + default synchronous mode (sync Rx with Tx) will be used, which means both
> + transimitter and receiver will send and receive data by following clocks
> + of transimitter.
> +- fsl,sai-asynchronous will be ignored if fsl,sai-synchronous-rx property is
> + already present.

Might be worth printing an error here.

Attachment: signature.asc
Description: Digital signature