Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

[Nicolin Chen]

On Thu, Aug 07, 2014 at 10:45:27AM +0100, Mark Brown wrote:
> On Tue, Aug 05, 2014 at 03:32:05PM +0800, Nicolin Chen wrote:
> > From: Nicolin Chen <Guangyu.Chen@xxxxxxxxxxxxx>
> > 
> > SAI supports these operation modes:
> > 1) asynchronous mode
> >    Both Tx and Rx are set to be asynchronous.
> > 2) synchronous mode (Rx sync with Tx)
> >    Tx is set to be asynchronous, Rx is set to be synchronous.
> > 3) synchronous mode (Tx sync with Rx)
> >    Rx is set to be asynchronous, Tx is set to be synchronous.
> > 4) synchronous mode (Tx/Rx sync with another SAI's Tx)
> > 5) synchronous mode (Tx/Rx sync with another SAI's Rx)
> 
> This seems to conflict with something else on my branch - not checked
> what.  Can you take a look please?

Ah...there is another patch that should haven been merged into for-next
is currently missing on the remote branch.

This one:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/079689.html
 
> > +Note:
> > +- If both fsl,sai-asynchronous and fsl,sai-synchronous-rx are absent, the
> > +  default synchronous mode (sync Rx with Tx) will be used, which means both
> > +  transimitter and receiver will send and receive data by following clocks
> > +  of transimitter.
> > +- fsl,sai-asynchronous will be ignored if fsl,sai-synchronous-rx property is
> > +  already present.
> 
> Might be worth printing an error here.

Hmm...Do I need to send a v2?

Thank you
Nicolin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/