Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put

From: Julia Lawall
Date: Fri Aug 08 2014 - 06:27:37 EST




On Fri, 8 Aug 2014, Uwe Kleine-König wrote:

> Hello,
>
> On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote:
> > From: Julia Lawall <Julia.Lawall@xxxxxxx>
> >
> > Of_node_put supports NULL as its argument, so the initial test is not
> > necessary.
> >
> > Suggested by Uwe Kleine-König.
> Thanks for picking up my suggestion.
>
> > The semantic patch that fixes this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e;
> > @@
> >
> > -if (e)
> > of_node_put(e);
> > // </smpl>
> >
>
> I added devicetree@xxxxxxxxxxxxxxx to Cc. Maybe they want to comment the
> series? If it's acceptable the logical next step is to add the patch to
> the collection of semantic patches, right?

Yes, I will do that.

julia