Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

From: Steven Rostedt
Date: Sat Aug 09 2014 - 08:45:05 EST


On Sat, 9 Aug 2014 08:15:14 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:


> As for idle tasks, I'm not sure about those, I think that we should say
> NO to anything that would require waking idle CPUs, push the pain to
> ftrace/kprobes, we should _not_ be waking idle cpus.

I agree, but I haven't had a chance to review the patch set (will
probably do that on Monday, just got back from vacation last week and
was inundated by other things). Does the idle waking happen only when
there's something queued in the call_rcu_tasks()? It should definitely
not be waking all the time. That's just wrong.

But if it only wakes when something is queued, it wouldn't be burdening
anything, unless it is needed.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/