Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM

From: Jiri Kosina
Date: Sat Aug 09 2014 - 16:40:11 EST


On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:

> If CONFIG_PM is not set:
>
> drivers/hid/wacom_sys.c:1436: warning: âwacom_reset_resumeâ defined but
> not used
>
> Protect the unused functions by #ifdef CONFIG_PM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks Geert.

hid-wacom is in a sort of temporary mode of operation, being moved from
Input to HID driver.

Adding Benjamin and Dmitry to CC, as this will likely still go through
Dmitry's queue.

> ---
> drivers/hid/wacom_sys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 3e388ec31da8..f0db7eca9023 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1416,6 +1416,7 @@ static void wacom_remove(struct hid_device *hdev)
> kfree(wacom);
> }
>
> +#ifdef CONFIG_PM
> static int wacom_resume(struct hid_device *hdev)
> {
> struct wacom *wacom = hid_get_drvdata(hdev);
> @@ -1436,6 +1437,7 @@ static int wacom_reset_resume(struct hid_device *hdev)
> {
> return wacom_resume(hdev);
> }
> +#endif /* CONFIG_PM */
>
> static struct hid_driver wacom_driver = {
> .name = "wacom",
> --
> 1.9.1
>

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/