Re: [PATCH] drivers: net: davinci_cpdma: drop devm_kfree of devm_kzalloc'd data

From: Daniel Mack
Date: Sun Aug 10 2014 - 16:27:26 EST


On 08/10/2014 09:58 PM, Himangi Saraogi wrote:
> devm_kfree should not have to be explicitly used.
>
> The Coccinelle semantic patch that fixes this problem is as follows:
>
> // <smpl>
> @@
> expression x,d;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-devm_kfree(d,x);
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@xxxxxxxxx>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

Acked-by: Daniel Mack <zonque@xxxxxxxxx>

However, you need to resend this patch after 3.17-rc1 has been released
and the net-next branch was opened again.


Thanks,
Daniel


> ---
> drivers/net/ethernet/ti/davinci_cpdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index 4a000f6..af673f5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -512,7 +512,6 @@ struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num,
> spin_lock_irqsave(&ctlr->lock, flags);
> if (ctlr->channels[chan_num]) {
> spin_unlock_irqrestore(&ctlr->lock, flags);
> - devm_kfree(ctlr->dev, chan);
> return ERR_PTR(-EBUSY);
> }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/