Re: [PATCH 6/6] ARM: dts: Add tps65090 FETs constraints

From: Mark Brown
Date: Tue Aug 12 2014 - 13:26:18 EST

On Tue, Aug 12, 2014 at 06:44:28PM +0200, Javier Martinez Canillas wrote:
> The tps65090 PMU data manual [0] has a table that list the
> "Recommended operating conditions" for each regulator. Add
> the information about the FET constraints to its dtsi file.

> tps65090_fet1: fet1 {
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <17000000>;
> };

No, this is completely broken and exactly the sort of thing that makes
doing generic device .dtsi a bad idea. We have absolutely no idea if
these voltage ranges are suitable for use on a given board using the
device, these are the design limits for the device but tell us nothing
about the system they are deployed in.

Attachment: signature.asc
Description: Digital signature