Re: [RFC/PATCH 1/2] perf top: Fix -z option behavior

From: Namhyung Kim
Date: Wed Aug 13 2014 - 00:53:00 EST


Hi David,

On Tue, 12 Aug 2014 13:01:41 -0600, David Ahern wrote:
> On 8/12/14, 2:16 AM, Namhyung Kim wrote:
>> The current -z option does almost nothing. It doesn't zero the
>> existing samples so that we can see profiles of exited process after
>> last refresh. It seems it only affects annotation.
>>
>> This patch clears existing entries before processing if -z option is
>> given. For this original decaying logic also moved before processing.
>
> This option was broken somewhere recently. I am on vacation for
> another week, so I can't do a git bisect myself but I recall it worked
> a year or so ago. Try v3.4 as a start point.

Are you sure? I don't recall seeing any big change in this area so I
guess the problem existed since long time ago. In fact I couldn't find
a logic to zero/clear out existing hist entries in a hists..

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/