Re: [Patch v2] freezer: check OOM kill while being frozen

[Michal Hocko]

On Tue 12-08-14 17:53:33, Cong Wang wrote:
> On Tue, Aug 12, 2014 at 4:44 AM, Michal Hocko <mhocko@xxxxxxx> wrote:
[...]
> >> @@ -147,12 +156,6 @@ void __thaw_task(struct task_struct *p)
> >>  {
> >>       unsigned long flags;
> >>
> >> -     /*
> >> -      * Clear freezing and kick @p if FROZEN.  Clearing is guaranteed to
> >> -      * be visible to @p as waking up implies wmb.  Waking up inside
> >> -      * freezer_lock also prevents wakeups from leaking outside
> >> -      * refrigerator.
> >> -      */
> >
> > This is an unrelated change.
> >
> 
> It is, because as I explained, __thaw_task() doesn't do what this comment
> says therefore needs this patch. Or you prefer to make it a separated patch?

It is outdated since a3201227f803. I would do it in a separate patch but
maybe just mention that the above commit has changed the implementation.

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/