Re: [PATCH] nfs: fix kernel warning when removing proc entry

From: Dan Aloni
Date: Sat Aug 16 2014 - 13:57:05 EST


On Thu, Aug 14, 2014 at 03:49:39PM -0700, Cong Wang wrote:
Signed-off-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>
> ---
> fs/nfs/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 1c5ff6d..1c57202 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -1429,7 +1429,7 @@ void nfs_fs_proc_net_exit(struct net *net)
>
> remove_proc_entry("volumes", nn->proc_nfsfs);
> remove_proc_entry("servers", nn->proc_nfsfs);
> - remove_proc_entry("fs/nfsfs", NULL);
> + remove_proc_entry("nfsfs", net->proc_net);
> }

nfs_fs_proc_net_init() has:

error_1:
remove_proc_entry("fs/nfsfs", NULL);

I think this needs fixing too, for consistency.

--
Dan Aloni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/