[PATCH] usb: phy: return -ENODEV on failure of try_module_get

From: Arjun Sreedharan
Date: Sun Aug 17 2014 - 14:35:31 EST


When __usb_find_phy_dev() does not return error and
try_module_get() fails, return -ENODEV

Signed-off-by: Arjun Sreedharan <arjun024@xxxxxxxxx>
---
drivers/usb/phy/phy.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
index 36b6bce..8ad3638 100644
--- a/drivers/usb/phy/phy.c
+++ b/drivers/usb/phy/phy.c
@@ -232,6 +232,7 @@ struct usb_phy *usb_get_phy_dev(struct device *dev, u8 index)
phy = __usb_find_phy_dev(dev, &phy_bind_list, index);
if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
dev_dbg(dev, "unable to find transceiver\n");
+ phy = IS_ERR(phy) ? phy : ERR_PTR(-ENODEV);
goto err0;
}

--
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/