Re: [PATCH 1/2] android: fix reference leak in sync_fence_create

From: Maarten Lankhorst
Date: Mon Aug 18 2014 - 09:07:06 EST


Hey,

Op 18-08-14 om 14:57 schreef Dan Carpenter:
> On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote:
>> According to the documentation sync_fence_create takes ownership of the point,
>> not a reference on the point.
>>
> What are the user visible effects of this bug? I assume this is a real
> bug but judging solely based on your patch description, it sounds like
> you could just update the documentation instead of changing the code.
>
Small memory leak on every created android fence when you run out of tree android drivers.

But because it happens every frame (or possibly even more often) it's worth fixing.

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/